Listen for removed inputs and unregister them #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dahlbyk
reviewed
Aug 13, 2023
dahlbyk
approved these changes
Aug 14, 2023
Comment on lines
+676
to
+679
| const validator = this.validators[inputUID]; | ||
| if (validator) { | ||
| formValidators.push(validator); | ||
| } |
There was a problem hiding this comment.
Agree it's curious that inputUID doesn't seem to have been deleted, but guarding against undefined also doesn't both me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issue #66 by looping through the
MutationRecord'sremovedNodesarray and removing entries for any validatable elements from the various state objects. This appears to fix the issue withisValidandisFieldValidfor my test case, but there are a couple parts I'm unsure of:undefinedvalidators ingetFormValidationTaskwhich seems to indicate thatthis.formInputs[formUID]still contains entries for removed inputs even though thesplicecall inuntrackFormInputshould have removed them.removedboolean that's currently being passed toscanand its children or to have a separate set of functions instead